Merged
Conversation
jeffsmale90
force-pushed
the
release/918.0.0
branch
from
95587ff to
5a223fd
Compare
jeffsmale90
force-pushed
the
release/918.0.0
branch
from
5a223fd to
ad1bd10
Compare
mj-kiwi
reviewed
Apr 16, 2026
- remove errant " - add comma between list of changes Co-authored-by: MJ Kiwi <me@mj.kiwi>
mj-kiwi
approved these changes
Apr 16, 2026
lwin-kyaw
approved these changes
Apr 16, 2026
OGPoyraz
reviewed
Apr 16, 2026
| ### Changed | ||
|
|
||
| - Bump `@metamask/gator-permissions-controller` from `^0.6.0` to `^0.8.0` ([#7274](https://github.com/MetaMask/core/pull/7274)), ([#7330](https://github.com/MetaMask/core/pull/7330)) | ||
| - Bump `@metamask/gator-permissions-controller` from `^0.6.0` to `^0.8.0`, ([#7274](https://github.com/MetaMask/core/pull/7274), [#7330](https://github.com/MetaMask/core/pull/7330)) |
Member
There was a problem hiding this comment.
Why did we adjusted previous release changelogs here and below? Are these really corrections or unintended changes?
Contributor
Author
There was a problem hiding this comment.
That is strange - I had a look, and it's the release branch automation resolving an issue with the original changelog (each change contributing to the line was wrapped in individual () rather than the entire list). We could revert it, but the next time we create a release it's going to do the same thing.
I repeated the release branch creation and it fixed it again. I think we will see these on a number of CHANGELOG files.
Member
There was a problem hiding this comment.
This might be because of new linter.
My only concern was
- **BREAKING:** Bump `@metamask/keyring-controller` peer dependency from `^18.0.0` to `^19.0.0` ([#4195](https://github.com/MetaMask/core/pull/4195))
line because it changes PR number.
OGPoyraz
approved these changes
Apr 16, 2026
geositta
added a commit
that referenced
this pull request
Apr 16, 2026
…sition-live-price-sync * origin/main: fix(transaction-pay-controller): resolve correct networkClientId for source chain in relay execute (#8492) Release/920.0.0 (#8494) chore: bump `accounts` deps (#8464) feat: adds auth to social controllers (#8485) Release/919.0.0 (#8482) feat(seedless-onboarding-controller): generic encryptor result type aligned with KeyringController TO-686 (#8411) Release/918.0.0 (#8478) chore: add periodic check for spl tokens (#8400)
4 tasks
pull Bot
pushed a commit
to dmrazzy/core
that referenced
this pull request
Apr 23, 2026
## Explanation MetaMask#8478 incorrectly "fixed" the PR link in @metamask/signature-controller's changelog, where the link text and link url referred to different PR numbers. This PR reverts and corrects the PR reference. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Changelog-only edit; no runtime code or dependencies are changed. > > **Overview** > Fixes an incorrect PR reference in `@metamask/signature-controller`’s changelog by updating the `23.0.0` entry for the breaking `@metamask/keyring-controller` peer dependency bump to point to the correct pull request. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit fb4ef9a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Releases
Breaking change to @metamask-gator-permissions-controller:
References
Checklist
Note
Medium Risk
Primarily a version/dependency release PR, but it propagates a breaking type change (
PermissionInfoWithMetadata.status) via a major bump that can break downstream TypeScript consumers.Overview
Cuts the
918.0.0release by bumping the root monorepo version and publishing@metamask/gator-permissions-controller4.0.0(noted as BREAKING due to adding astatusfield toPermissionInfoWithMetadata, resolved from on-chain data).Updates the dependency chain to consume the new major:
@metamask/signature-controlleris released as39.2.0and now depends on@metamask/gator-permissions-controller@^4.0.0, and@metamask/shield-controllerupdates to@metamask/signature-controller@^39.2.0; lockfile and changelogs are updated accordingly.Reviewed by Cursor Bugbot for commit 0371831. Bugbot is set up for automated code reviews on this repo. Configure here.